Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix line breaks in plain text email #15115

Merged
merged 2 commits into from
Aug 29, 2016
Merged

Conversation

tillkruss
Copy link
Collaborator

@tillkruss tillkruss commented Aug 28, 2016

#15108 broke the new-lines in the plain text email for notifications.

This PR fixes those line breaks.

For future PRs the importance of new-lines in plain text emails has been highlighted by only using echo statements in email-plain.blade.php.

CRLFs have been replaced by LFs, because SwiftMailer canonicalizes them anyhow.

@tillkruss tillkruss changed the title Fix line breaks in plain text email [5.3] Fix line breaks in plain text email Aug 28, 2016
@taylorotwell
Copy link
Member

Why do we have to manually echo "\n"... why not just put actual line breaks in the file like you would a Blade template?

@tillkruss
Copy link
Collaborator Author

@taylorotwell Because of the conditionals. We'd end up with weird blank lines in between sections.

@tillkruss
Copy link
Collaborator Author

HTML collapses vertical line breaks and even horizontal spaces. Plain text emails are more like Markdown.

@taylorotwell taylorotwell merged commit 2df8485 into laravel:5.3 Aug 29, 2016
@tillkruss tillkruss deleted the patch-2 branch August 29, 2016 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants