[5.3] Hide empty paginators

[garygreen]

Fixes #15124

[taylorotwell]

What is $elements and where does that variable come from?

[taylorotwell]

"Elements" is only passed by the length aware paginator.

[GrahamCampbell]

You just just ask the paginator how large it is.

[GrahamCampbell]

count($paginator)

[garygreen]

Not sure why I made that more complicated than it needs to be. I've updated PR to just check for ->count() on the paginator @taylorotwell @GrahamCampbell 😄

[nhowell]

It still renders when there is only one page but there is more than one item to display, which is different from 5.2.

[GrahamCampbell]

Meh, that's ok I think. Kinda odd to hide in that case.

[garygreen]

Er so that's why I had the code as I did... I wasn't going mad! I think it should hide it imo, if there's only one page then no point displaying pagination.

[nhowell]

@GrahamCampbell I don't think it's ok to not render when there's only one item on the page, while still rendering when there are two items on the page. That's just plain inconsistent.

[nhowell]

I would prefer that it doesn't render the pagination links at all unless there is more than one page. Plus, it would make it consistent with 5.2.

But if that's too much trouble, we should at least render the pagination links when there is only one item on the page as well:

// Change this:
@if ($paginator->count() > 1)

// To this:
@if (! $paginator->isEmpty())

[GrahamCampbell]

Oh right I see what you mean. This code should be > 0 not > 1. Please PR. :)

[nhowell]

Oh, and I just realized there is another issue with the current code.

Say you used have 26 items and you $items->paginate(25). The first page has 25 items, while the second page will only have one item and therefore the pagination links will be hidden on the second page.

[garygreen]

I think the code should be what I had it as before....

For the non simple paginators it should just be:

@if (count($elements))

Then for the simple paginators it should be...

@if (!$paginator->onFirstPage() || $paginator->hasMorePages())

[nhowell]

@garygreen Oh, I like that.

And in fact, couldn't we use @if (!$paginator->onFirstPage() || $paginator->hasMorePages()) for both types of paginators? I think that would actually retain the same behavior of 5.2 by not rendering at all unless there is more than one page.

[taylorotwell]

Reverted. Please send a correct PR.