[5.3] Add split method to collection class #15302

freekmurze · 2016-09-06T09:13:26Z

This PR adds a split method to Illuminate\Support\Collection that splits a collection into the given number of groups.

$collection = collect(['a', 'b', 'c', 'd'])->split(2);

$collection->count(); // returns 2

$collection->first(); // returns a collection with 'a' and 'b';
$collection->last(); // returns a collection with 'c' and 'd';

GrahamCampbell · 2016-09-06T09:15:49Z

src/Illuminate/Support/Collection.php

@@ -921,6 +921,23 @@ public function slice($offset, $length = null)
    }

    /**
+     * Split a collection into a certain number of groups.
+     *
+     * @param  int $numberOfGroups


missing space

Sorry about that, fixed.

Still not correct?

GrahamCampbell · 2016-09-06T09:18:30Z

src/Illuminate/Support/Collection.php

@@ -920,6 +920,23 @@ public function slice($offset, $length = null)
        return new static(array_slice($this->items, $offset, $length, true));
    }

+     /**


This whole block is indented by one too many spaces

Honest mistake, fixed now (using the patch file from style ci)

Still incorrect.

StyleCI aligned it to your method definition which is also indented incorrectly.

Wut? Can StyleCI be incorrect? 😄

StyleCI is correct according to Laravel's rules. The phpdoc must be aligned to match the method. There is no fixer to change the alignment of the actual method definition yet.

GrahamCampbell · 2016-09-06T09:30:24Z

src/Illuminate/Support/Collection.php

+    /**
+     * Split a collection into a certain number of groups.
+     *
+     * @param  int    $numberOfGroups


When I said a missing space, I really did mean exactly one space was missing.

Please put exactly two spaces inbetween int and $.

Done, my apologies for all the trouble.

GrahamCampbell · 2016-09-06T12:50:59Z

src/Illuminate/Support/Collection.php

+    public function split($numberOfGroups)
+    {
+        if ($this->isEmpty()) {
+            return $this;


should return a new instance here

arrilot · 2016-09-06T12:57:25Z

Refs #10889

freekmurze added 2 commits September 6, 2016 11:09

add split function to collection

ff03fb6

fix nitpicks

044c392

GrahamCampbell reviewed Sep 6, 2016
View reviewed changes

fix cs

e7f64ce

GrahamCampbell reviewed Sep 6, 2016
View reviewed changes

more cs fixes

f9e67a7

GrahamCampbell reviewed Sep 6, 2016
View reviewed changes

moar cs

f159dc9

GrahamCampbell reviewed Sep 6, 2016
View reviewed changes

return new instance

baf09ec

taylorotwell merged commit 2bfef8b into laravel:5.3 Sep 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.3] Add split method to collection class #15302

[5.3] Add split method to collection class #15302

freekmurze commented Sep 6, 2016

GrahamCampbell Sep 6, 2016

freekmurze Sep 6, 2016

GrahamCampbell Sep 6, 2016

GrahamCampbell Sep 6, 2016

freekmurze Sep 6, 2016

GrahamCampbell Sep 6, 2016

GrahamCampbell Sep 6, 2016

freekmurze Sep 6, 2016

GrahamCampbell Sep 6, 2016

GrahamCampbell Sep 6, 2016

freekmurze Sep 6, 2016

GrahamCampbell Sep 6, 2016

freekmurze Sep 6, 2016

arrilot commented Sep 6, 2016

[5.3] Add split method to collection class #15302

[5.3] Add split method to collection class #15302

Conversation

freekmurze commented Sep 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arrilot commented Sep 6, 2016