Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix pcntl extension error for queue #15393

Merged
merged 1 commit into from
Sep 13, 2016
Merged

[5.3] Fix pcntl extension error for queue #15393

merged 1 commit into from
Sep 13, 2016

Conversation

srmklive
Copy link
Contributor

Fixes #14909

@@ -6,6 +6,7 @@
use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputArgument;
use RuntimeException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort by length.

@GrahamCampbell
Copy link
Member

Thanks, but you forgot to add a throws annotation. :)

@srmklive
Copy link
Contributor Author

@GrahamCampbell You are right :). Fixing it.

@@ -47,6 +48,7 @@ public function __construct(Listener $listener)
* Execute the console command.
*
* @return void
* @throws RuntimeException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline and slash.

@taylorotwell taylorotwell merged commit 40438b3 into laravel:5.3 Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants