[5.3] Fix foreach blade compiler #15485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix tests, I bring |
|
Yeah Can you please write a test to make sure your change solves the issue and that it won't get broken after any later changes? |
Yes, please write a test or two. |
|
added |
themsaid
reviewed
Sep 18, 2016
| @@ -624,7 +624,7 @@ protected function compileForelse($expression) | |||
| { | |||
| $empty = '$__empty_'.++$this->forelseCounter; | |||
|
|
|||
| preg_match('/\( *(.*) +as *([^\)]*)/', $expression, $matches); | |||
| preg_match('/\( *(.*) +as *([^\)]*)/s', $expression, $matches); | |||
There was a problem hiding this comment.
Can you please add the i here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New line in
@foreachand@forelseshould be allowed:@foreach([ 'foo' ] as $var) @endforeachAnd this feature is also supported before 5.3
I removed amiss
iregex modifier and addedsmodifier.