[5.3] Granular notification queue jobs #15681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks notification queued job to queue a job for each notifiable / channel combination. The reason for this is with the prior setup of using a single job, if one channel fails to send and the job retries all channels you could deliver duplicate/N number of notifications on a given channel, possibly costing you money if the channel charges money per notification.
|
This looks great! Thanks Taylor. |
reinink
reviewed
Sep 29, 2016
| { | ||
| $this->channels = $channels; |
There was a problem hiding this comment.
Minor: Should you put this line after the other two, since it was the last item in the method signature?
There was a problem hiding this comment.
I sort by length, signature order.
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks notification queued job to queue a job for each notifiable
/ channel combination. The reason for this is with the prior setup of
using a single job, if one channel fails to send and the job retries
all channels you could deliver duplicate/N number of notifications on a
given channel, possibly costing you money if the channel charges money
per notification.