Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add workaround to use Memcached 3.0.0 with Many, Fix issues in #13002 #15739

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
3 participants
@nikkiii
Copy link
Contributor

commented Oct 3, 2016

This fixes the issues with referencing null in #13002, along with supporting Memcached 3.0.0's changed getMulti call.

If the ReflectionMethod call isn't satisfactory, we could also compare versions with something like this:

version_compare('3.0.0', phpversion('memcached'), '>=')

@taylorotwell

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Yeah I would use phpversion instead of Reflection.

@nikkiii

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

version_compare/phpversion doesn't seem to work as-is, in my testing it was shown as extremely unreliable, likely because of the "beta" designation on 3.0.0.

Version comparison using preg_match, or even strpos possibly? I'd hate to do it, but it could be cleaner than Reflection...

@GrahamCampbell GrahamCampbell changed the title Add workaround to use Memcached 3.0.0 with Many, Fix issues in #13002 [5.3] Add workaround to use Memcached 3.0.0 with Many, Fix issues in #13002 Oct 3, 2016

@GrahamCampbell

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Do a compare on the extension version.

@taylorotwell

This comment has been minimized.

Copy link
Member

commented Oct 4, 2016

version_compare and probably phpversion do not consider beta or RC releases to be final releases. But, I still think that is probably the best way to determine the version.

@taylorotwell

This comment has been minimized.

Copy link
Member

commented Oct 4, 2016

Can you post a link to the change-log for this Memcached 3.0 and how to install it?

@nikkiii

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2016

The change is not exactly documented well, but:
php-memcached-dev/php-memcached#229

It's the standard package in Dotdeb and possibly Ubuntu 16.04 PHP7 installs, and manual build/installation information can be found here: https://github.com/php-memcached-dev/php-memcached

@taylorotwell taylorotwell merged commit 38e247e into laravel:5.3 Oct 5, 2016

1 of 2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has failed - 1 file needs addressing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

apollopy added a commit to apollopy/laravel-memcached that referenced this pull request Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.