Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] LengthAwarePaginator custom pageName and currentPage #15870

Merged
merged 1 commit into from
Oct 13, 2016
Merged

[5.3] LengthAwarePaginator custom pageName and currentPage #15870

merged 1 commit into from
Oct 13, 2016

Commits on Oct 12, 2016

  1. Update LengthAwarePaginator.php 

    Ran into minor problem using multiple LengthAwarePaginators on a single page with alternate 'pageName' properties. Traced problem to the attached proposed change.

When checking the current page for a LengthAwarePaginator instance, any non-default pageName is not sent to resolveCurrentPage and as such 1 is always returned (unless pageName of 'page' is used).
    jivemonkey2000 committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    02121e3 View commit details
    Browse the repository at this point in the history