New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] return null if an empty key was passed to getAttribute #15874

Merged

taylorotwell merged 2 commits into laravel:5.3 from themsaid:fix/getAttributeNull

Oct 12, 2016

Member

themsaid commented Oct 12, 2016

No description provided.

themsaid mentioned this pull request

$model->getAttribute(null) causes SIGSEGV #15830

Closed

themsaid added 2 commits

October 12, 2016 20:57


           return null if an empty key was passed to getAttribute

a7c9086


           fix code style

fc013e4

taylorotwell merged commit cd3e3cd into laravel:5.3

catalinux commented Nov 16, 2016

should't we have a throw new InvalidArgumentException('Key can\'t be empty '); instead of a return?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment