Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add flag for select type of create controller #15993

Merged
merged 5 commits into from
Oct 19, 2016

Conversation

eskrano
Copy link

@eskrano eskrano commented Oct 18, 2016

Add flag for select type of create controller (resource controller or no).

Add flag for select type of create controller (resource controller or no).
@GrahamCampbell GrahamCampbell changed the title Add flag for select type of create controller [5.3] Add flag for select type of create controller Oct 18, 2016
@browner12
Copy link
Contributor

and here is the slippery slope we go down with that commit of mine.

@GrahamCampbell
Copy link
Member

Please implement my review comments.

@browner12
Copy link
Contributor

i guess my personal opinion on this is to not merge. my argument in the initial commit is we are going after 90% of the use cases. The 10% can use the dedicated command for their need.

The problem if we implement this is, now do we go and add options for the --table and --path options for making a migration?

You can see how this quickly becomes a tangle of code.

my 2 cents. thanks.

@taylorotwell
Copy link
Member

If I was going to have this flag I would just call it something like -r not -c_r

@taylorotwell
Copy link
Member

Though I do think this command has the potential to seriously bloat as noted.

@eskrano
Copy link
Author

eskrano commented Oct 18, 2016

@taylorotwell update . set -r flag

@taylorotwell taylorotwell merged commit c24ae1f into laravel:5.3 Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants