Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Updates to configuration loader #16080

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Conversation

hitman99
Copy link
Contributor

@hitman99 hitman99 commented Oct 24, 2016

There was an issue when loading configuration file in Linux/Unix. When file is actually a symbolic link, the path gets messed up and none of the configuration provided in the target file is accessible because the path with dot notation contains everything in between the link and the target file.

There was an issue when loading configuration file in Linux/Unix. When file is actually a symbolic link, the path gets messed up and none of the configuration provided in the target file is accessible because the path with dot notation contains everything in between he link and the target file.
@GrahamCampbell GrahamCampbell changed the title Updates to configuration loader [5.3] Updates to configuration loader Oct 24, 2016
@taylorotwell
Copy link
Member

I'm confused what would be causing an issue. We resolve the real path to the file which should resolve symlinks, then we take dirname. What is the issue?

@hitman99
Copy link
Contributor Author

The issue is, when using the following structure of custom config directory:

# ls -ltra
total 8
drwxrwxr-x    9 www-data www-data      4096 Oct 24 09:26 ..
lrwxrwxrwx    1 root     root            23 Oct 24 09:30 mysql_config.php -> ..data/mysql_config.php
lrwxrwxrwx    1 root     root            26 Oct 24 09:30 influxdb_config.php -> ..data/influxdb_config.php
lrwxrwxrwx    1 root     root            28 Oct 24 09:30 gp_rest_endpoints.php -> ..data/gp_rest_endpoints.php
lrwxrwxrwx    1 root     root            33 Oct 24 09:30 ..data -> ..109810_24_10_12_30_36.527846506
drwxr-xr-x    2 root     root            83 Oct 24 09:30 ..109810_24_10_12_30_36.527846506
drwxrwxrwx    3 root     root          4096 Oct 24 09:30 .

@taylorotwell
Copy link
Member

Shouldn't you just make your symlinks absolute?

@hitman99
Copy link
Contributor Author

hitman99 commented Oct 24, 2016

I would if I could, but I'm running my Laravel application inside the Kubernetes cluster (backed by Docker) and providing configuration via Kubernetes ConfigMaps, thus I have no controls over the directory structure Kubernetes creates for me.

@taylorotwell taylorotwell merged commit 590bc97 into laravel:5.3 Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants