Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix Translator::sortReplacements() #16221

Merged
merged 1 commit into from
Nov 2, 2016
Merged

[5.3] Fix Translator::sortReplacements() #16221

merged 1 commit into from
Nov 2, 2016

Conversation

lucasmichot
Copy link
Contributor

Fix \Illuminate\Translation\Translator::sortReplacements as an array is expected.

@GrahamCampbell GrahamCampbell changed the title [5.3] Fix \Illuminate\Translation\Translator::sortReplacements [5.3] Fix Translator::sortReplacements() Nov 2, 2016
@GrahamCampbell
Copy link
Member

Looks 👍 in principle. It's also possible the phpdoc was wrong though.

@lucasmichot
Copy link
Contributor Author

Seems It's only used in makeReplacements, which expects an array

Le 2 novembre 2016 à 08:40:48, Graham Campbell (notifications@github.com) a
écrit:

Looks 👍 in principle. It's also possible the phpdoc was wrong though.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16221 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfWQzr07jvPw7iQeBkrj4qDPeK_b3sjks5q6D6AgaJpZM4Km62n
.

@GrahamCampbell
Copy link
Member

Could you add a test please?

@vlakoff
Copy link
Contributor

vlakoff commented Nov 2, 2016

Method added in 2d35eef.

@taylorotwell taylorotwell merged commit 2f2da14 into laravel:5.3 Nov 2, 2016
@lucasmichot lucasmichot deleted the feature/5.3/sort-replacements branch January 10, 2017 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants