[5.3] Fix Auth::onceUsingId by reversing the order of retrieving the id in SessionGuard #16373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
Auth::onceUsingId()in one of my middleware, and when implementing this I noticed thatAuth::id()andAuth::user()->iddidn't return the same id anymore.Auth::id()was returning the ID of the user that was logged in before callingAuth::onceUsingId(), whileAuth::user()returned the new logged in user.This pull requests reverses the order in which the id is retrieved, so that the overridden user will always be returned if it has one, otherwise it looks at the current session. This fixes the issue explained above.