Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Slack improvements #16451

Merged
merged 7 commits into from
Nov 18, 2016
Merged

[5.3] Slack improvements #16451

merged 7 commits into from
Nov 18, 2016

Conversation

standaniels
Copy link
Contributor

This PR adds support for markdown in a Slack attachment and adds support for setting the attachment's footer.

@standaniels standaniels changed the title Slack improvements [5.3] Slack improvements Nov 17, 2016
@standaniels
Copy link
Contributor Author

I'll write the tests shortly.

Signed-off-by: Stan Daniëls <stan@inovamedia.nl>
@alexbowers
Copy link
Contributor

alexbowers commented Nov 18, 2016

Is there a reason mrkdwn_in is used? rather than the more common md or the full markdown?

Edit: Ah, i misread it. It appears thats Slack's API. My bad.

@taylorotwell taylorotwell merged commit d2bc064 into laravel:5.3 Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants