Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Check for typos in first fluent route segment #16748

Merged
merged 1 commit into from Dec 11, 2016

Conversation

JosephSilber
Copy link
Member

Currently, this will not throw:

Route::midddleware('auth')->get('/', 'HomeController@index');

But this will:

Route::as('home')->midddleware('auth')->get('/', 'HomeController@index');

This PR adds a guard against the first example too.

@JosephSilber JosephSilber changed the title [5.4] Check allowed attributes in first segment [5.4] Check for typos in first segment Dec 11, 2016
@JosephSilber JosephSilber changed the title [5.4] Check for typos in first segment [5.4] Check for typos in first fluent route segment Dec 11, 2016
@GrahamCampbell
Copy link
Member

Seems fair. 👍

@GrahamCampbell
Copy link
Member

Ideally, we'd have a unit test too please. ;)

@taylorotwell taylorotwell merged commit b3780d7 into laravel:master Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants