New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Remove unnecessary check #16752

Merged

taylorotwell merged 2 commits into laravel:5.3 from laurencei:patch-1

Dec 12, 2016

Contributor

laurencei commented Dec 11, 2016

There is no need for count($events) - it was made redundant when this commit occurred: ffabb9a

Basically the only thing that matters now is the $eventsRan count


          Update ScheduleRunCommand.php

381163b

GrahamCampbell changed the title ~~Remove unnecessary check~~ [5.3] Remove unnecessary check


          Update ScheduleRunCommand.php

5c02ac5

Contributor Author

laurencei commented Dec 11, 2016

Cleaned it up a bit further - remove the unnecessary counting etc

taylorotwell merged commit 76ad41b into laravel:5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment