[5.3] Collection::min() incorrectly excludes 0 when calculating minimum

[thecrypticace]

This commit: e2d317e introduced a (hopefully unintentional) BC break in min() that causes the following to fail:

collect([0, 1, 2, 3])->min() // returns: 1

This is because filter calls array_filter without a callback which in turn removes all falsy values, not just null ones.

I've also updated the changed code in Collection::max() for consistency.

[thecrypticace]

Wow that was fast…

[modmac]

Is it ok that:

collect([1, null, 3, 4])->min() // returns 1

but:

min([1, null, 3, 4]) // returns null

?

[GrahamCampbell]

Seems pretty stupid to use maps here when we could have just used a loop and saved ourselves all the bugs, and the performance hit, since php doesn't lazily iterate them - we have to go round again and again, for each map.

[taylorotwell]

Benchmark results iterating over 1 million items using foreach, map with closure, map with named function, etc:

ForEach : 0.11297199726105
MapClosure : 0.16404168605804
MapNamed : 0.11067249774933

[GrahamCampbell]

@taylorotwell What if you want chained maps and filters though? That's where you see the slow down, vs doing it inline with continue statements in a foor loop.