New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Allow base collections in BelongsToMany::sync #16882

Merged

taylorotwell merged 2 commits into laravel:5.3 from sebastiandedeyne:allow-base-collections-in-sync

Dec 20, 2016

Contributor

sebastiandedeyne commented Dec 20, 2016

Currently sync throws an error when providing a base collection object as your set of id's.

This method allows ->sync(collect([1, 2, 3])).

Since there's no type hint, and it currently throws an error—so it can't accidentally be done—I thinkthis change is non-breaking.

sebastiandedeyne added 2 commits

December 20, 2016 14:51


          Allow base collections in BelongsToMany::sync


          Updated docs

46d3f8e

taylorotwell merged commit 7baa075 into laravel:5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment