[5.4] Moved tinker out to an external package #17002

Merged
merged 1 commit into from Dec 28, 2016

Projects

None yet

5 participants

@GrahamCampbell
Member

No description provided.

@GrahamCampbell GrahamCampbell Moved tinker out to an external package
ee8d26c
@JosephSilber
Contributor

What's the motivation behind this?

@GrahamCampbell
Member

It's dependency heavy, and php-parser conflicts are becoming more and more of an issue for people these days.

@themsaid
Member

WHY? 😳

@GrahamCampbell
Member

The plan is to still have tinker in the default app structure, but it will be removable if people want.

@JosephSilber
Contributor

I can't imagine building a Laravel app without Tinker.

Maybe that's just me.

@GrahamCampbell
Member

I can't imagine building a Laravel app without Tinker.

Yeh, the idea isn't to remove it from laravel, rather, just make it so that it can be removed, in order to install something else that conflicts with it. This also means that tinker can now be dropped into lumen. :D

@taylorotwell
Member

It would be in the default "require" so it would still ship out of the box. It would just be its own component.

@taylorotwell taylorotwell merged commit 180cac1 into master Dec 28, 2016

4 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/styleci/push The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@GrahamCampbell GrahamCampbell deleted the tinker branch Dec 28, 2016
@bobthecow
Contributor

php-parser conflicts are becoming more and more of an issue for people these days.

Are they?

@bobthecow
Contributor

Oh, like #16773?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment