[5.3] Update ChannelManager #17068
Merged
[5.3] Update ChannelManager #17068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better fix would be to rename the variable in the loop, instead of the argument name. Also, we don't use snake_case. |
|
i will change the code asap |
GrahamCampbell
requested changes
Jan 1, 2017
| @@ -59,7 +59,7 @@ public function sendNow($notifiables, $notification, array $channels = null) | |||
| foreach ($notifiables as $notifiable) { | |||
| $notificationId = Uuid::uuid4()->toString(); | |||
|
|
|||
| $channels = $channels ?: $notification->via($notifiable); | |||
| $channels = $use_channels ?: $notification->via($notifiable); | |||
There was a problem hiding this comment.
Better to rename the LHS variable name here, and keep the param the same.
|
how about name: viaChannels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the channels arg are null
the first $notifiable will call "via" method and set $channels value
the second $notifiable be skipped "via" method