Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Allow float value as expiration in Memcached cache store #17106

Merged
merged 1 commit into from
Jan 3, 2017
Merged

[5.3] Allow float value as expiration in Memcached cache store #17106

merged 1 commit into from
Jan 3, 2017

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Jan 3, 2017

Since the rest of drivers accept float values, however Carbon::addMinutes() will convert the float to integer so 0.9 will be 0 causing no caching to happen.

@themsaid themsaid mentioned this pull request Jan 3, 2017
Closed
@taylorotwell taylorotwell merged commit e9ed216 into laravel:5.3 Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@themsaid @taylorotwell