New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix match only APP_KEY in replace #17151

Merged
merged 2 commits into from Jan 8, 2017

Conversation

Projects
None yet
3 participants
@TheoKouzelis
Copy link
Contributor

TheoKouzelis commented Jan 5, 2017

Changed str_replace to preg_replace to ensure no clashes with other environment variables.


Closes #17140.

TheoKouzelis added some commits Jan 4, 2017

Fix issue #17140 match only APP_KEY in replace
Changed str_replace to preg_replace to ensure no clashes with other
environment variables

@GrahamCampbell GrahamCampbell changed the title Fix issue #17140 match only APP_KEY in replace [5.3] Fix match only APP_KEY in replace Jan 5, 2017

@taylorotwell taylorotwell merged commit 53cc628 into laravel:5.3 Jan 8, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
$escapedKey = preg_quote('='.$this->laravel['config']['app.key'], '/');
return "/^APP_KEY$escapedKey/m";
}

This comment has been minimized.

@tillkruss

tillkruss Jan 8, 2017

Member

This does not read nice to me 😕

This comment has been minimized.

@TheoKouzelis

TheoKouzelis Jan 9, 2017

Contributor

Is there anything you would recommend to make it read better?

This comment has been minimized.

@tillkruss

tillkruss Jan 9, 2017

Member

I made a quick PR: #17226

This comment has been minimized.

@TheoKouzelis

TheoKouzelis Jan 10, 2017

Contributor

Thanks for the PR and the code review.

tillkruss added a commit to tillkruss/framework that referenced this pull request Jan 9, 2017

taylorotwell added a commit that referenced this pull request Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment