Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Document ability to give an array to HasOne::withDefault() #17514

Merged
merged 1 commit into from
Jan 24, 2017
Merged

[5.4] Document ability to give an array to HasOne::withDefault() #17514

merged 1 commit into from
Jan 24, 2017

Conversation

miclf
Copy link
Contributor

@miclf miclf commented Jan 24, 2017

PR #16382 added the ability to pass an array of attributes to set on the default model that can be returned by hasOne Eloquent relationships but docblocks hadn’t been updated accordingly to this change. So I thought I’ll fix that :-)

PR #16382 added the ability to pass an array of attributes to set on the default model that can be returned by `hasOne` Eloquent relationships but docblocks hadn’t been updated accordingly to this change.
@GrahamCampbell GrahamCampbell changed the title Document ability to give an array to HasOne::withDefault() [5.4] Document ability to give an array to HasOne::withDefault() Jan 24, 2017
@taylorotwell taylorotwell merged commit c96e640 into laravel:5.4 Jan 24, 2017
@miclf miclf deleted the patch-1 branch January 24, 2017 21:13
@miclf
Copy link
Contributor Author

miclf commented Jan 24, 2017

@GrahamCampbell should this change also be applied on 5.3? This is the version where the documented code has been introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants