[5.4] Don’t require PhpRedis extension for tests #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ]; | ||
|
|
||
| if (extension_loaded('redis')) { |
There was a problem hiding this comment.
bad idea really, because these tests won't show up as skipped, they'll just get hidden all together
|
Wait so now the Predis tests won't run on my machine if I don't have PHPRedis installed? |
|
No, same like before. Predis will run as long as host/port are configured. If not they are not set, PHPUnit will skip the tests. PhpRedis will only be tested if the extension is installed. If not, only Predis is tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #17882.