Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Adding SameSite to config/sessions #18059

Merged
merged 4 commits into from
Mar 1, 2017
Merged

[5.5] Adding SameSite to config/sessions #18059

merged 4 commits into from
Mar 1, 2017

Conversation

fernandobandeira
Copy link
Contributor

This allow us to specify a default value for this option on the sessions config file...

We could rename the methods setDefaultPathAndDomain and getPathAndDomain to something else like setDefaultOptions and getDefaultOptions would it be a good idea?

@sisve
Copy link
Contributor

sisve commented Feb 23, 2017

Renaming the methods would be a breaking change; couldn't you just create two new methods; getSameSite and setSameSite?

@fernandobandeira
Copy link
Contributor Author

Yes I could, but it's already being used for secure too so it already doesn't make that much sense...

@taylorotwell taylorotwell merged commit 3c73d99 into laravel:master Mar 1, 2017
@taylorotwell
Copy link
Member

Change this to same_site since we always use snake_case in config and also defaulted it to null in several places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants