[5.5] Allow 500 custom error pages when not in debug mode #18481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so good that is simple enough for us to override the |
|
Is this a breaking change? |
|
@Kyslik - no, it shouldnt be. It you dont have a custom 500 page in your app, it'll just display the normal 'whoops' page as it does now. If you already have a 500 page in your app, then this just ensures it is displayed in all scenarios, not just some. |
Kyslik
reviewed
Apr 24, 2017
| return $this->toIlluminateResponse($this->convertExceptionToResponse($e), $e); | ||
| } | ||
|
|
||
| if (! $this->isHttpException($e)) { | ||
| $e = new HttpException(500, $e->getMessage()); |
There was a problem hiding this comment.
If you want this in 5.4
Anyone who uses PHPStorm and auto-import suggest importing HttpException (which might not exist)
import use Symfony\Component\HttpKernel\Exception\HttpException; instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @taylorotwell in PR laravel/docs#3165
Currently, even with a
views/errors/500.blade.phpfile, a non HttpException 500 error will still display a "whoops" page (with or without stack trace depending on env settings).This PR changes behavior only when
APP_DEBUG=false, to use a custom 500 error page if one is available. If no custom 500 page is available it will still display the same whoops error page (without a stack trace).It solves issues such as #17586, #14137 & #10466
With
APP_DEBUG=true(even with a custom 500 page):With
APP_DEBUG=falseand a no defined custom 500 error page:With
APP_DEBUG=falseand a custom 500 error page: