Repository navigation
[5.4] Allow boolean keys for Collection::groupBy method - #18674
Merged
Merged
Conversation
The following PR adds support for boolean keys when used in ``groupBy`` method of ```\lluminate\Support\Collection``. Related to #18672 problem.
Member
|
I think you can currently do: This will partition the collection into two groups, trues and falses. |
Contributor
Author
|
@themsaid it's not the case with an example you have provided. If you just took a look at an example I have provided in #18672 issue, where the p.s. in general PHP you are allowed to have I hope you got my point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds support for boolean keys when used in
groupBymethod of\lluminate\Support\Collection. Related to #18672 issue.