[5.4] Add assertSeeText() and assertDontSeeText() to TestResponse#18690
Merged
taylorotwell merged 2 commits intolaravel:5.4from Apr 6, 2017
Merged
[5.4] Add assertSeeText() and assertDontSeeText() to TestResponse#18690taylorotwell merged 2 commits intolaravel:5.4from
taylorotwell merged 2 commits intolaravel:5.4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds two new assertions to the TestResponse class:
assertSeeText()andassertDontSeeText().Motivation
These assertions are really helpful when asserting against HTML responses, as visual design of the page shouldn't make a test pass or fail. Given the following HTML:
I would currently test this using the following assertion:
But whenever a designer thinks it would look better if it was also italic, or add some extra CSS classes, my test would break. All I really care about is that the views are shown on the page. The
assertSeeText()assertion solves this issue: