New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] make Request::has() work like Collection::has() #18715

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
3 participants
@themsaid
Member

themsaid commented Apr 7, 2017

Currently Request::exists() work like Collection::has().

In this PR:

-Request::has() will work like Collection::has().
-Request::exists() was removed.
-Request::filled() was added to work like old Request::has().

@laurencei

This comment has been minimized.

Show comment
Hide comment
@laurencei

laurencei Apr 7, 2017

Member

Rather than removing Request::exists() - is it worth perhaps leaving it and under the hood just call Request::has()? i.e. make it an alias?

One less breaking change for everyone to worry about during the upgrade?

Member

laurencei commented Apr 7, 2017

Rather than removing Request::exists() - is it worth perhaps leaving it and under the hood just call Request::has()? i.e. make it an alias?

One less breaking change for everyone to worry about during the upgrade?

@taylorotwell taylorotwell merged commit 2d22de0 into laravel:master Apr 7, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment