New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Update AuthenticatesUsers.php #18746

Merged

taylorotwell merged 1 commit into laravel:5.4 from webmake:non_string_properties_in_auth

Apr 10, 2017

Contributor

webmake commented Apr 9, 2017 •

edited

Additional checking for non string properties, fixes for #18697


          Update AuthenticatesUsers.php

47e1f3a

Additional checking for non string properties

tillkruss changed the title ~~Update AuthenticatesUsers.php~~ [5.4] Update AuthenticatesUsers.php

Contributor

devcircus commented Apr 9, 2017

My thoughts on this from #18697

The methods in these traits are simply starter boilerplate code. The intent is for you to use them if they match your specific use-case and if not, override them in your controller. Personally, I would get more mileage from these methods if they were left untouched. With these added validations, I'll need to override more often.

taylorotwell merged commit a513aaa into laravel:5.4

themsaid mentioned this pull request

Unexpected argument exception within login process #18697

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment