[5.5] Snake and Kebab handle lower case words as expected.

[PeterDKC]

It seems like unexpected results to return "snaked" words only if those words or letters start with uppercase and to explicitly ignore a non-letter character followed by an letter.

Current behavior:

>>> \Illuminate\Support\Str::snake('Random words Here')
=> "randomwords_here"
>>> Illuminate\Support\Str::snake('Random wORDS  p     here')
=> "randomw_o_r_d_sphere"

Proposed change passes current unit tests and doesn't change existing behavior.

[ntzm]

This could be a BC for someone who is using these functions for URL slugs or identifiers

[jhoff]

@marktopper This wouldn't re-case words, only upper cases the first, so the delimiter is still added before each upper case letter. In that example, it would be random_w_o_r_d_s_p_here.

[PeterDKC]

This could be a BC for someone who is using these functions for URL slugs or identifiers

@ntzm I considered that quite thoroughly, but I feel like anyone using it for that would have accounted for it locally when they actually tried to use it, which is exactly why we discovered it was behaving oddly. We were writing factories for User Permissions, which are kebabbed: is-admin or marketing-manager for instance. instead we got:

>>> $faker->words(3, true)
=> "delectus quos possimus"
>>> Illuminate\Support\Str::kebab($faker->words(3, true))
=> "etaperiamex"

Clearly the intended result is not to have onelongwordsausage, so I feel like anyone who was actually looking for slugs would have accounted for it if they payed attention to the output at all. If they didn't, then yes, they might need to adjust some things.