[5.5] Use of argument (un)packing in throw_if/unless helpers #19255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduma
changed the title
src/Illuminate/Support/helpers.php
Outdated
| * @return void | ||
| */ | ||
| function throw_if($boolean, $exception, $message = '') | ||
| function throw_if($boolean, $exception, ...$arguments) |
There was a problem hiding this comment.
I would rename this to $parameters.
There was a problem hiding this comment.
True. At least I've learned something 😄
There was a problem hiding this comment.
Uh... I've got that backwards.
I was simply saying that I'd use $parameters because that's what we use all over in our __call methods. I wasn't thinking from a semantic perspective.
From a semantic perspective, $arguments actually makes more sense.
So I take back what I said originally. I now believe that $arguments is actually a better name 🙈
because "argument is the value/variable/reference being passed in, parameter is the receiving variable used w/in the function/block" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to pass more than one argument to the exception class.
For example base exception class accepts message and code, so after this PR we can do this: