Refresh updated_at timestamp on soft delete

[haakym]

For issue #19529

Performing a soft delete updates the updated_at timestamp in the database but not on the model. Assumed the fix would be in line with the desired behaviour?

The changes to SoftDeletes makes the testDeleteSetsSoftDeletedColumn method on DatabaseSoftDeletingTraitTest fail, have written the code to get it passing again, but unsure if my thinking is in the right direction for the test.

Would appreciate any feedback as still pretty new to contributing. Thanks!

[Namoshek]

Thank you for the fix! Unfortunately, I think your change forces an updated_at attribute on the model, even if public $timestamps = false; is set on it. I doubt there are many models with SoftDeletes enabled while not having normal timestamps. But to be sure it always works, something along the lines

protected function runSoftDelete()
{
    $query = $this->newQueryWithoutScopes()->where($this->getKeyName(), $this->getKey());

    $time = $this->freshTimestamp();

    $this->{$this->getDeletedAtColumn()} = $time;
    $attributes = [$this->getDeletedAtColumn() => $this->fromDateTime($time)];

    // first check of the if is pretty much optional but a safe bet
    if ($this instanceof Concerns\HasAttributes && $this->timestamps === true) {
        $this->{$this->getUpdatedAtColumn()} = $time;
        $attributes[$this->getUpdatedAtColumn()] = $this->fromDateTime($time);
    }

    $query->update($attributes);
}

seems more realistic to me. I'm also only a new Laravel contributor though and still trying to understand everything behind the scenes... :)

For full coverage, this obviously requires two tests thanks to the if statement.