Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Always use handle function for commands. #19827

Merged
merged 1 commit into from
Jun 29, 2017
Merged

[5.5] Always use handle function for commands. #19827

merged 1 commit into from
Jun 29, 2017

Conversation

lucasmichot
Copy link
Contributor

@lucasmichot lucasmichot commented Jun 29, 2017

In commands and command stubs, fire has been replaced by handle since 970836c (version 5.0.30)

@taylorotwell taylorotwell merged commit e899d31 into laravel:master Jun 29, 2017
@browner12
Copy link
Contributor

should Console/Command be updated to reflect this change? if we're going to get rid of fire and make handle the standard, this would be the time to do it

@lucasmichot
Copy link
Contributor Author

I think we should keep Console/Command as it so that console commands from your app still work with fire.

@lucasmichot lucasmichot deleted the feature/master/console-handle branch June 29, 2017 17:13
@browner12
Copy link
Contributor

hmm... i guess I would lean towards removal. if we target 5.5 we could make this breaking change, and include a note in the upgrade guide.

this helps us keep a simpler code base (not by much in this case) and maintain a consistent interface.

@lucasmichot
Copy link
Contributor Author

Yeah this would make sense @browner12
Up to @taylorotwell

@sylarbg
Copy link

sylarbg commented Jun 30, 2017

Generators for models and mails are broken
"laravel/framework": "5.5.*"
[Symfony\Component\Debug\Exception\FatalThrowableError]
Call to undefined method Illuminate\Console\GeneratorCommand::fire()

@lucasmichot
Copy link
Contributor Author

Good catch @sylarbg , see #19839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants