[5.5] Ensure a 304 response is properly returned. #19867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieutu
added a commit
to mathieutu/framework
that referenced
this pull request
Jul 4, 2017
* laravel/master: (519 commits) [5.5] Remove useless variables. (laravel#19866) Ensure a 304 response is properly returned. (laravel#19867) Apply fixes from StyleCI (laravel#19876) Stay consistant with expected exceptions and test messages. (laravel#19873) formatting formatting Improve ThrottleRequests. Allow passing of data to the view Apply fixes from StyleCI (laravel#19852) Testing existing feature (laravel#19847) verison Call parent::handle command (laravel#19839) Update ViewController.php Apply fixes from StyleCI (laravel#19836) Update CallbackEvent.php (laravel#19834) Add Route::view() helper Use proper assertions. (laravel#19831) Make illuminate/container require psr-11 (laravel#19829) Fix some docblocks and missing properties. (laravel#19825) formatting ... # Conflicts: # src/Illuminate/Foundation/helpers.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can decide at any time to return a
304response.This PR ensures that the content is
nulland that the following headers are always removed:AllowContent-EncodingContent-LanguageContent-LengthContent-MD5Content-TypeLast-Modified