[5.5] Add extension point for custom ControllerDispatcher #20031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzm
reviewed
Jul 13, 2017
| @@ -54,7 +55,7 @@ public function dispatch(Route $route, $controller, $method) | |||
| * @param string $method | |||
| * @return array | |||
| */ | |||
| public static function getMiddleware($controller, $method) | |||
| public function getMiddleware($controller, $method) | |||
There was a problem hiding this comment.
This will make it a breaking change, should probably target 5.5 instead
There was a problem hiding this comment.
Appears to have been changed to laravel:master
sisve
changed the title
| * @param string $method | ||
| * @return mixed | ||
| */ | ||
| public function dispatch(Route $route, $controller, $method); |
There was a problem hiding this comment.
This is slightly unfortunate as typically a contract can't depend on any outside library. This depends on Illuminate\Routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an extension point to write a custom dispatcher. This allows me to write a custom resolving logic that can use functionality not originally available in Laravel; like handling of nullable type hints (PHP 7.1) and optional route parameters. Laravel currently calls app::make on those parameters, even if they are neither bound, nor buildable
Changes
Point 1 and 2 are breaking changes if someone has already replaced their dispatcher by replacing the Route (hardcoded
new ControllerDispatcherin runController) and the Router (hardcodednew Routein newRoute).Point 2 isn't necessary for my use-case, but seemed to be within the scope of the ControllerDispatcher contract.