[5.5] Add console events #20298
Merged
[5.5] Add console events #20298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would name it CommandFinished maybe instead of CommandTerminating. |
|
Ping. |
|
Renamed |
|
I'm curious why you did not pass the output interface as well? |
|
I've added this change : 545c30d Not sure it really makes sense to add it to |
|
I would add it to both. I can't think of why we wouldn't. |
|
Added |
|
@lucasmichot can u update the docs about this as well ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add console events - Reboot of #16355 (originally targeting 5.3)
Related to #15613