Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit-test.stub to use RefreshDatabase trait #20308

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Update unit-test.stub to use RefreshDatabase trait #20308

merged 1 commit into from
Jul 28, 2017

Conversation

techenby
Copy link

@techenby techenby commented Jul 28, 2017

Since Illuminate\Foundation\Testing\RefreshDatabase is used by default now, this stub should reflect it and match the test.stub.

Since `Illuminate\Foundation\Testing\RefreshDatabase` is used by default now, this stub should reflect it, to match the test.stub.
@lucasmichot
Copy link
Contributor

As this is a stub, this is kept as it on purpose

@techenby
Copy link
Author

Then why was the test.stub updated? https://github.com/laravel/framework/blob/master/src/Illuminate/Foundation/Console/stubs/test.stub

When running php artisan make:test ModelTest --unit, on a 5.5 project I currently get the old database migration and transaction traits, instead of the new RefreshDatabase trait.

But when I run php artisan make:test ExampleTest on the same project I do get the RefreshDatabase trait.

It doesn't make sense to have it in one place but not the other, but if it was done on purpose, feel free to close the PR.

@taylorotwell taylorotwell merged commit b797ad4 into laravel:master Jul 28, 2017
@techenby techenby deleted the patch-1 branch July 28, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants