Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] phpredis Fixes #20316

Merged
merged 2 commits into from
Jul 29, 2017
Merged

[5.5] phpredis Fixes #20316

merged 2 commits into from
Jul 29, 2017

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Jul 29, 2017 •
edited
Loading

More fixes to the phpredis wrapper.

  • Make sure prefix is respected when raw commands are executed
  • Make sure the return value of setNx and hsetNx is an integer like in predis

@GrahamCampbell
Copy link
Member

Looks solid. 👍

@themsaid
Copy link
Member Author

@GrahamCampbell welcome back, I kind of miss your 👍 & 👎 parties :D

@GrahamCampbell
Copy link
Member

Yeh, I had to unwatch laravel/framework I'm afraid. Too many notifications for me to meaningfully read and review. ;)

@taylorotwell taylorotwell merged commit ca19e22 into laravel:master Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@themsaid @GrahamCampbell @taylorotwell