Only install Whoops in development, by default #20412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garygreen
force-pushed
the
whoops-dev-only
branch
from
b2def98
to
aba20be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops should be encouraged to only be used in Development based environments, otherwise accidentally enabling debug mode on production would be catastrophic. It would expose every env including database passwords, encryption keys, API keys, etc. Mistakes happen. If this happened in a corporate environment, it would ruin a business.
With this PR, it will only be installed by default on development however you are free to add whoops to your
composer.jsonin yourrequireblock, assuming you would like to be an absolute lunatic and install whoops on production 馃槃