[5.5] Re-use implicit binding resolving logic that is already present on model #20618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balping
changed the title
balping
added a commit
to balping/laravel-hashslug
that referenced
this pull request
Aug 18, 2017
Because it has been possible to do this in a clear way, since this PR was merged: laravel/framework#20618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my original intention in #20521
However I was inattentive there: when I moved the resolving logic to eloquent model, I made only one replacement, while 3 could have been done. (+ I was wrong on calling that implicit binding while that was about explicit binding without callback function, ie.
Route::model)This PR fixes that by reusing the resolving logic already being present in eloquent's
resolveRouteBindingNote that all three occurrences used to implement exactly the same logic, so this PR, together with the merged original one, removes code repetition too.
There was another related PR where Taylor Otwell said
But I hope he meant the controversy around
UrlRoutable. This PR has nothing to do with that, it simply removes duplicated code and completes my original intention of making it possible to alter implicit route model binding resolution by overriding a method on a model.