Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Allow for configuration of sticky databases #20746

Merged
merged 1 commit into from
Aug 25, 2017
Merged

[5.5] Allow for configuration of sticky databases #20746

merged 1 commit into from
Aug 25, 2017

Conversation

laurencei
Copy link
Contributor

Allow #20445 to be configurable

I can forsee edge cases where people might not want this functionality (i.e. doing a small write followed by unrelated large read in same request - such as an application that logs all user actions) - so we can easily make it configurable for those that want either behavior.

Also this way we preserve current behavior - because the config will be null on existing applications (since the value doesnt exist) - so this reduces risk of strange breaking behavior during a 5.5 upgrade.

Instead I propose to mention this new config option in the 5.5 upgrade guide, for those that want to enable it. And meanwhile I can do another PR for laravel/laravel to include it in the default config stack and in the docs.

I'll do the other PR's for you if this gets accepted.

@taylorotwell
Copy link
Member

So it will default to false / null I guess? That's your intention?

@laurencei
Copy link
Contributor Author

laurencei commented Aug 25, 2017 via email

@taylorotwell taylorotwell merged commit 8f28801 into laravel:master Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants