[5.5] fixed a bug in app:name command #20766
Merged
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As you see
the old
ModelFactory.php
has been removed and simplified.But the
AppNameCommand.php
file is not still updated correspondingly!https://github.com/laravel/framework/blob/master/src/Illuminate/Foundation/Console/AppNameCommand.php#L227
Steps To Reproduce:
php artisan app:name Test
See that the
database/factories/UserFactory.php
file is still usingApp\User
Should have been
Test\User
.