[5.5] Make Optional@__call really macroable

[n7olkachev]

We need to firstly check existence of macro and only then proxy __call to the value. Otherwise it won't be really macroable (because macros won't work for Optional with value inside).

[thecrypticace]

This is an interesting case. I would think the check should use is_object && method_exists first before the macro. Otherwise you could register a macro and accidentally break tons of stuff. And maybe by something you don't directly control, like an auto-registered service provider.

Though, this way of doing it wouldn't work for objects implementing __call. Honestly, it feels wrong that this class is even Macroable because it's meant only as a "do this if not null" pass through.

Do with this what you wish. This is just me putting my two cents in.

[n7olkachev]

Indeed, but we already have similar Macroable functionality in, for example, Eloquent\Builder class, which is also could be easily broken with global macros.

[thecrypticace]

True but the builder is only delegated to by a model if a method isn't found. Here optional isn't going to define any methods except the ones necessary to delegate to the underlying value.

It's mainly about how it's going to be used. ¯\_(ツ)_/¯

[taylorotwell]

Tempted to just make it not macroable at this point.

[n7olkachev]

But you can just move this behavior to your macro:

Optional::macro('present', function () {
    if (is_object($this->value)) {
        return $this->value->present();
    }
    return new Optional(null);
});

[n7olkachev]

You are saying it like you are going to have tons of macros and it is really painful to write 3 lines of code. Do you really think that it is good idea to remove feature just not to write 3 lines of code in your macro?

You can checkout similar monads or Optional from Java for possible macros. Without this PR, it won't be possible.

[n7olkachev]

Optional::macro('orElse', function ($value) {
    if (is_object($this->value)) {
        return $this->value; // nope, I don't want to proxy orElse
    }
    return value($value);
});

[n7olkachev]

@derekmd jfyi 1 year+ passed and there were no PRs. There were no need to be rude.