Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Fix class name in generated class file #20961

Merged
merged 2 commits into from
Sep 4, 2017
Merged

[5.5] Fix class name in generated class file #20961

merged 2 commits into from
Sep 4, 2017

Commits on Sep 4, 2017

  1. Fix class name in generated class file. 

    If a class name used in a make commands starts with a slash the generated file will have the slash in the class name creating syntax error in class file. For example, artisan make modeld command (i.e. php artisan make:model \Foo) will generate file with the class name \Foo (i.e. class \Foo { ..... } ).  Removing the beginning slash in the GeneratorCommand::qualifyClass() method will generate file will a valid class name.
    @jrl05k
    jrl05k committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    3788f15 View commit details
    Browse the repository at this point in the history

  2. Update GeneratorCommand.php

    @taylorotwell
    taylorotwell committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    c017677 View commit details
    Browse the repository at this point in the history