[5.5] Specify lower case column_name (fixes #20190)
#21037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themsaid
changed the title
column_name (fixes #20190)column_name (fixes #20190)
|
Thanks |
gonzahce
added a commit
to gonzahce/framework
that referenced
this pull request
Sep 6, 2017
* catch errors as well (laravel#21047) * return from Validator::setCustomMessages (laravel#21046) * show exception class in JSON (laravel#21043) * [5.5] Removed listener listensFor (laravel#21039) * remove listensFor * remove listensFor * Specify lower case `column_name` (fixes laravel#20190) (laravel#21037) * [5.5] Add policies method to Gate (laravel#21036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MySqlProcessorassumes that the result from MySQL contains a lowercase column calledcolumn_name.On my installation, if I run the query from
compileColumnListingof MySqlGrammarThe result contains the column
COLUMN_NAMEin uppercase.I don't really know where this is changed. In the driver? Maybe it makes sense to change the query in
MySqlGrammarto ensure the correct case of the result:In reference to: #20190