Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Move validated request input extraction into its own method #21192

Merged
merged 1 commit into from
Sep 18, 2017
Merged

[5.5] Move validated request input extraction into its own method #21192

merged 1 commit into from
Sep 18, 2017

Conversation

Lidbetter
Copy link
Contributor

@Lidbetter Lidbetter commented Sep 14, 2017

For my project I want to tweak that from $request->only(...) to $request->all(...) I could just override both validateWith and validate methods, but I would rather separate them then only change the bit I care about.

Reasoning:
If either of those methods' internal logic change in the future, my overrides should still work.

The 3 lines I am extracting are duplicated in those two methods, I think there is some general benefit of putting them in a single method.

@Lidbetter Lidbetter changed the title Move validated request input extraction into its own method [5.5] Move validated request input extraction into its own method Sep 14, 2017
@taylorotwell taylorotwell merged commit d87a199 into laravel:5.5 Sep 18, 2017
@Lidbetter Lidbetter deleted the move-input-from-rules-to-method branch September 18, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants