[5.6] Include job ID in the output of the queue:work Artisan command #21204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
Looks fine to go to 5.5? |
|
@deleugpn The command output will change on different minor releases. Not a good to thing. Better for 5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, when working on a project that required a queue, I was trying to debug my app and track down certain jobs. The
queue:workArtisan command didn't print out the job id, so it was a little harder for me to figure out what was going on. This PR adds the job ID to the command. Currently the output of thequeue:workcommand looks like this:With this PR, the output looks like this:
Please note how the job ID is just after the timestamp. I made this PR against master because it might break some apps that parse the output of this command. For example, if you were using the grep functionality in Logstash. So it would be better to save it for Laravel 5.6.