Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Updates output property visibility on Artisan command events #21356

Merged
merged 1 commit into from
Sep 24, 2017
Merged

[5.5] Updates output property visibility on Artisan command events #21356

merged 1 commit into from
Sep 24, 2017

Conversation

nunomaduro
Copy link
Member

This PR addresses the events CommandStartingand CommandFinished making the output implementation accessible via a listener.

With this change, the listener can output information before and after every command execution.

@nunomaduro nunomaduro changed the title [5.5] Updates output property visibity on artisan command events [5.5] Updates output property visibility on artisan command events Sep 23, 2017
@nunomaduro nunomaduro changed the title [5.5] Updates output property visibility on artisan command events [5.5] Updates output property visibility on Artisan command events Sep 23, 2017
@taylorotwell taylorotwell merged commit 81672ba into laravel:5.5 Sep 24, 2017
@deleugpn
Copy link
Contributor

why not a getter instead?

@nunomaduro
Copy link
Member Author

@deleugpn When an event is broadcast, all of its public properties are automatically serialized and broadcast as the event's payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants