New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Revert Collection::sortBy to 5.4 behaviour #21382

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@themsaid
Member

themsaid commented Sep 25, 2017

@taylorotwell taylorotwell merged commit c91cf5f into laravel:5.5 Sep 25, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details

@GrahamCampbell GrahamCampbell changed the title from Revert Collection::sortBy to 5.4 behaviour to [5.5] Revert Collection::sortBy to 5.4 behaviour Sep 25, 2017

@denaje

This comment has been minimized.

Show comment
Hide comment
@denaje

denaje Oct 6, 2017

Contributor

@themsaid @taylorotwell You seem to be going back and forth a lot on this stable sort thing. Is there a plan to settle on it one way or another? I need to know if I should be able to count on having stable sorting in collections or if I need to continue to roll my own solution for the foreseeable future.

Contributor

denaje commented Oct 6, 2017

@themsaid @taylorotwell You seem to be going back and forth a lot on this stable sort thing. Is there a plan to settle on it one way or another? I need to know if I should be able to count on having stable sorting in collections or if I need to continue to roll my own solution for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment