Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Revert Collection::sortBy to 5.4 behaviour #21382

Merged
merged 1 commit into from
Sep 25, 2017
Merged

[5.5] Revert Collection::sortBy to 5.4 behaviour #21382

merged 1 commit into from
Sep 25, 2017

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Sep 25, 2017

@taylorotwell taylorotwell merged commit c91cf5f into laravel:5.5 Sep 25, 2017
@GrahamCampbell GrahamCampbell changed the title Revert Collection::sortBy to 5.4 behaviour [5.5] Revert Collection::sortBy to 5.4 behaviour Sep 25, 2017
@elynnaie
Copy link

elynnaie commented Oct 6, 2017

@themsaid @taylorotwell You seem to be going back and forth a lot on this stable sort thing. Is there a plan to settle on it one way or another? I need to know if I should be able to count on having stable sorting in collections or if I need to continue to roll my own solution for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants